Closed colbychaskell closed 7 months ago
The source code has not been amalgamated. @colbychaskell Please read and follow the Contribution Guidelines.
The source code has not been amalgamated. @colbychaskell Please read and follow the Contribution Guidelines.
Pushed a new commit that handles this a lot more cleanly. Will fix check errors soon
The source code has not been amalgamated. @colbychaskell Please read and follow the Contribution Guidelines.
@nlohmann Sorry for the delay, this is ready to be reviewed when you get a chance!
@nlohmann it looks like something unrelated to these changes is breaking in the CI compiler tests as it's trying to get CMake and Ninja.
Would this be related to recent CI fixes? The checks passed successfully with the same changes about a week ago.
No, unfortunately this is unrelated. I am getting so tired of fixing CI issues rather than improving the library. I'll check during the weekend.
The failing checks are an unrelated CI issue that will be fixed in #4215
The failing checks are an unrelated CI issue that will be fixed in #4215
Please rebase to the develop
branch. This should fix the CI. I would like to take this as last item for the upcoming release.
@nlohmann rebased and good to go now!
Thanks a lot!
Addresses issue #4163.
Fixes the deprecation warning for char_traits with signed and unsigned char. These types have been explicitly marked as deprecated in the latest version of LLVM.
More information on the deprecation can be found in this announcement from LLVM.
This creates a custom char_traits struct that will extend the std::char_traits struct. The primary template will simply use the std::char_traits for a given type, but the specializations will provide char_traits methods and traits for non-standard char types (unsigned and signed char).
Functions that relied on std::char_traits for these unsupported types have been updated to use the custom char_traits implementation.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filessingle_include/nlohmann/json.hpp
andsingle_include/nlohmann/json_fwd.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.