nlohmann / json

JSON for Modern C++
https://json.nlohmann.me
MIT License
41.33k stars 6.58k forks source link

Fix failing CI checks #4215

Closed colbychaskell closed 7 months ago

colbychaskell commented 7 months ago

Multiple CI checks have been failing because of an issue using the lukka/get-cmake action in the CI workflow. The latest version of lukka/get-cmake uses node20 instead of node16 so it requires higher versions of the c standard libraries. To keep this working with the older GCC versions, I have specified the previous version of the lukka/get-cmake.

There also seems to be a new failing clang tidy check in one of the tests due to a static cast to a derived type. I assume this is due to the jobs container updating the clang tidy version. Added a NOLINT to this line to get the CI passing for now.


Pull request checklist

Read the Contribution Guidelines for detailed information.

Please don't

nlohmann commented 7 months ago

Thanks a lot! L

coveralls commented 7 months ago

Coverage Status

coverage: 100.0%. remained the same when pulling 1c41daada498fe99867a93062ee7677476b2228c on colbychaskell:fix-ci-get-cmake into 6eab7a2b187b10b2494e39c1961750bfd1bda500 on nlohmann:develop.