nlohmann / json

JSON for Modern C++
https://json.nlohmann.me
MIT License
41.25k stars 6.57k forks source link

Clone is long due to large history #4370

Closed Nir-Az closed 1 month ago

Nir-Az commented 1 month ago

Description

json repo history is very big. CMake ExternalProject_Add does not support shallow clone of a specific commit, that makes us work hard to minimize the clone part that happens on build step.

I suggest to use git tools to reduce history size W/O history repo is ~ 7 [MB] with history it's ~ 185 [MB]

Reproduction steps

image

Expected vs. actual results

Here how it looks w/o history image

Minimal code example

No response

Error messages

Clone step occasionally fail on timeout

Compiler and operating system

Windows / Linux

Library version

3.11.3 but also latest

Validation

nlohmann commented 1 month ago

Use the .xz archives instead.

Nir-Az commented 1 month ago

That an option yes. Managed WA it this way: https://github.com/IntelRealSense/librealsense/pull/12914/files

But releases are not git source controlled and may be broken in the future, if you rename it in the future my link will be broken right?

reducing the history is a better long run approach IMO.

Thoughts?

nlohmann commented 1 month ago

I had this discussions a while ago. I will not change this repository's history. If you want a quick download, take the .xz archive. If you want to check out the repository, deal with its size. Sorry.

Nir-Az commented 1 month ago

NP, just raised an enhancement. Thanks for the hard work on this great repository.