search

nlopes / actix-web-prom

Actix-web middleware to expose Prometheus metrics
MIT License
93 stars 56 forks source link

Upgrade to latest actix #21

Closed Igosuki closed 4 years ago

Igosuki commented 4 years ago

Hello Norberto, I tried to update to actix's latest release, hope I did it correctly.

Igosuki commented 4 years ago

n.b. : use pin project instead of making B unpin since that conflicts with the other middlewares.

nlopes commented 4 years ago

Will take a look at this this week hopefully. Apologies for the late reply

Igosuki commented 4 years ago

Asbolutely no worries, we've all got lives ;)

nlopes commented 4 years ago

Do you mind taking a look at https://github.com/nlopes/actix-web-prom/pull/25 ? Will merge with your thumbs up @Igosuki .

I kept all your commits. Do you happen to know of a middleware this messes with? As a side note, I bumped to the latest alphas of actix-web and actix-http.