search

nlopes / actix-web-prom

Actix-web middleware to expose Prometheus metrics
MIT License
92 stars 56 forks source link

actix 3 release bump #32

Closed clux closed 3 years ago

clux commented 3 years ago

Thanks for this crate! This is probably a simple one :-)

actix 3 was just released, and it probably requires a bump of actix herein, as I'm seeing this when upgrading:

error[E0271]: type mismatch resolving `<actix_web_prom::PrometheusMetrics as actix_web::dev::Transform<<impl actix_service::ServiceFactory as actix_service::ServiceFactory>::Service>>::Request == actix_web::dev::ServiceRequest`
   --> version.rs:100:14
    |
100 |             .wrap(prometheus.clone())
    |              ^^^^ expected struct `actix_web::service::ServiceRequest`, found struct `actix_web::dev::ServiceRequest`
    |
    = note: perhaps two different versions of crate `actix_web` are being used?
nlopes commented 3 years ago

Which version of the crate are you using? 0.5.0 should have actix-web at version 3 and actix-service at 1.0.6.

If you're not on 0.5.0, please upgrade to 0.5.0.

clux commented 3 years ago

Ah, 0.5.0 wasn't out when I tested. That version works. Thank you!

nlopes commented 3 years ago

Thanks for raising, truly appreciate it!