Closed arthurlm closed 3 years ago
Fairly happy to do so if you'd be so kind as to set that PR.
I think actix-web
is getting fairly close to a 4.0
release so I started a PR that brings actix-web-prom
in line with the latest beta. I'm also going to try to take the -beta.N
approach to give the community more flexibility.
You can check my PR at https://github.com/nlopes/actix-web-prom/pull/57
Hi,
There currently multiple PRs pending to allow usage of
actix-web-prom
withactix-web = "4.0.0"
(see: https://github.com/nlopes/actix-web-prom/pull/45, https://github.com/nlopes/actix-web-prom/pull/44).I have read discussions and seen that maintainers do not want to have
beta
version inmaster
branch. This is perfectly understandable. Indeed, libraries releases should never depends on beta versions.However, it would be awesome if you could provide a branch allowing users to continue using
actix-web-prom
with new versions ofactix-web
.I have done this in my fork (see changes) and it works out of the box changing
Cargo.toml
like bellow:Would you like me to create a PR on branch
actix-next
in your repository (and not merging intomaster
) ?Do you have any better ideas to allow users continue using your works with
actix-web = "4.0.0-beta.X"
?