search

nlopes / actix-web-prom

Actix-web middleware to expose Prometheus metrics
MIT License
89 stars 56 forks source link

Updated to support actix-web 4.0.0-beta.9 #58

Closed mkawalec closed 2 years ago

mkawalec commented 2 years ago

Most are pretty mechanistic changes to accommodate the updates to the API in v4. One quirk is that MessageBody demands the error type to be actix_http::Error as it's implementation of MessageBody for ResponseBody<B> puts a From<actix_http::Error> constraint on the body.

It might be useful to release this as a beta release in order to unblock people willing to use actix v4 for it's latest Tokio support.

mkawalec commented 2 years ago

This looks redundant given https://github.com/nlopes/actix-web-prom/pull/57 :D

nlopes commented 2 years ago

Indeed redundant after #57 but thank you still!