search

nlopes / actix-web-prom

Actix-web middleware to expose Prometheus metrics
MIT License
92 stars 56 forks source link

WIP: add regex replacements #6

Open jcgruenhage opened 5 years ago

jcgruenhage commented 5 years ago

This allows users to specify a set of regexes that should be replaced in the path, to avoid having a gigantic set of metrics when the path contains resource IDs

jcgruenhage commented 5 years ago

force push to rebase onto the new changes on master

jcgruenhage commented 5 years ago

@nlopes this is marked as WIP because there is a bug in here somewhere. In the app I wrote this for, once switch from master to this version, for some endpoints metrics aren't recorded, and sometimes already recorded metrics also get lost and it all starts over, without any panics or errors in the logs. With the version from the master branch, it all works fine. Could you have a look?

jcgruenhage commented 4 years ago

I'm currently occupied with deployments. Once I'm back from in dev land from my ops tasks, I'll update this with 1.39 in mind and try to reproduce the bug I was experiencing.

nazar-pc commented 4 years ago

I believe #20 will make this mostly unnecessary