search

nlopes / actix-web-prom

Actix-web middleware to expose Prometheus metrics
MIT License
89 stars 56 forks source link

Rename the default histogram #75

Open albertogg opened 11 months ago

albertogg commented 11 months ago

By renaming this metric we are making the package comply with Prometheus naming convention.

Reference: https://prometheus.io/docs/practices/naming/

albertogg commented 11 months ago

I think that this should be the default name but we can also solve this issue with #70

nlopes commented 11 months ago

I'd consider this a breaking change - I've gone against semantic versioning before when I'm under 1.0. I might do it for this one as well. Thanks for sending - definitely something to change.