fix: avoid ddos by checking registered paths

nlopes / actix-web-prom

Actix-web middleware to expose Prometheus metrics

MIT License

89 stars 56 forks source link

fix: avoid ddos by checking registered paths #79

Closed lauti7 closed 1 week ago

lauti7 commented 9 months ago

This PR:

checks resources map to avoid recording whatever path the client sends

nlopes commented 6 months ago

hi @lauti7, super appreciative of this PR. I'd like this to be optional and probably not the default. That's because organisations might actually get value from mapping 404s this way (even if annoying/wasteful when ddos occur).

ranger-ross commented 1 week ago

@nlopes I also took a crack at this in https://github.com/nlopes/actix-web-prom/pull/84

lauti7 commented 1 week ago

closing in favor of #84 - better implementation