search

nlopes / libhoney-rust

Rust library for sending data to Honeycomb
MIT License
23 stars 16 forks source link

feat: runtime-async-std #61

Open Fishrock123 opened 3 years ago

Fishrock123 commented 3 years ago

Adds a compile-time flag to support running on async-std's threadpool rather than a tokio one.

This also switches out Reqwest for Surf, which has multiple http client backends, including a Hyper (tokio-compatible) one.

Note: these feature flags are mutually exclusive, and building does not work if none is specified (i.e. --no-default-features).

cc @nlopes

nlopes commented 3 years ago

Apologies @Fishrock123 but I merged a PR that improved things a bit with reqwest (in terms of dependencies) but that will force you to rebase.

I also noticed that tests didn't successfully run, something to take a look at.

Overall I like this change (the smaller the footprint the better).

Fishrock123 commented 3 years ago

Ah shoot. It would have been easier to merge that after since surf is still playing catch-up a bit here.

ericsampson commented 3 years ago

is this work resumable @Fishrock123? :)