Open ramosbugs opened 3 years ago
The client flush method is implemented in terms of stopping and restarting the Transmission: https://github.com/nlopes/libhoney-rust/blob/2f7cdc8b9035e2c1c9605c3476640e7f70400471/src/client.rs#L122-L133
flush
Transmission
Unfortunately, the stop event causes a break that breaks out of the loop and doesn't send any of the queued events: https://github.com/nlopes/libhoney-rust/blob/62d6da9f6ba49cded6770ea127cd3cf803b653e2/src/transmission.rs#L212-L215
break
I think the code should probably jump to this line instead of breaking out of the loop: https://github.com/nlopes/libhoney-rust/blob/62d6da9f6ba49cded6770ea127cd3cf803b653e2/src/transmission.rs#L238
The client
flushmethod is implemented in terms of stopping and restarting theTransmission: https://github.com/nlopes/libhoney-rust/blob/2f7cdc8b9035e2c1c9605c3476640e7f70400471/src/client.rs#L122-L133Unfortunately, the stop event causes a
breakthat breaks out of the loop and doesn't send any of the queued events: https://github.com/nlopes/libhoney-rust/blob/62d6da9f6ba49cded6770ea127cd3cf803b653e2/src/transmission.rs#L212-L215I think the code should probably jump to this line instead of breaking out of the loop: https://github.com/nlopes/libhoney-rust/blob/62d6da9f6ba49cded6770ea127cd3cf803b653e2/src/transmission.rs#L238