nlordell / ethrpc-rs

Ethereum transport-agnositic JSON RPC implementation
Apache License 2.0
2 stars 2 forks source link

getBlockByNumber returns more than accounted for. #11

Open bh2smith opened 11 months ago

bh2smith commented 11 months ago

I can see that you are trying to separate the Transaction type from the before it is actually mined, by excluding things like block_number

However this rpc endpoint to fetch hydrated block returns transactions containing block_numbers:

curl -X POST $NODE_URL --data '{"jsonrpc":"2.0","method":"eth_getBlockByNumber","params":["0xffff1f", true],"id":1}' | jq '.result.transactions'

unfortunately this data is being lost in transmission.

I believe it should be Optional field (since its None when pending)