Recommended changes resulting from automated audit

nlowe / Cake.MiniCover

A Cake Addin for Minicover, making it as easy as possible to get cross-platform code coverage on dotnet core

https://cakebuild.net/dsl/minicover/

MIT License

4 stars 1 forks source link

Recommended changes resulting from automated audit #7

Open Jericho opened 5 years ago

Jericho commented 5 years ago

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

[ ] You are currently referencing Cake.Core 0.29.0. Please upgrade to 0.33.0
[ ] You are currently referencing Cake.Common 0.29.0. Please upgrade to 0.33.0
[ ] The nuget package for your addin should use the cake-contrib icon. Specifically, your addin's .csproj should have a line like this: <PackageIconUrl>https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png</PackageIconUrl>.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.

This issue was created by a tool: Cake.AddinDiscoverer version 3.12.1

nlowe commented 5 years ago

@jericho FYI some automated process seems to be stuck. This is the third issue I've seen for this in the last hour.

Jericho commented 5 years ago

If you close the issue without addressing the recommendations, the automated process will keep creating a new issue every time I restart it which unfortunately I've had to do several times because we keep triggering github's abuse detection. I will probably restart the process several more times over the next 24 hours until we successfully audit all cake addins so I recommend you leave this issue open for a little while.

nlowe commented 5 years ago

Thanks for the info. The other two issues are showing as closed by you, not sure if that was automated or not. I'll try to take a look at this during this week.

Jericho commented 5 years ago

I thought you were the one who kept closing the issues but when I paid a little more attention I realized you were right: the automated process keeps closing and reopening a new issue. I'm really sorry about that. I made the process more resilient and it should now be able to resume even after a crash due to triggering github's abuse detection.

Jericho commented 5 years ago

Just checking: there hasn't been any new duplicated issues, right? The audit tool has finished processing all addins and, as far as I can tell, it hasn't created any new dupes since you alerted me. Again, thanks for letting me know and sorry about the previous dupes.

nlowe commented 5 years ago

Correct, as far as I can tell no new duplicates have been created. Thanks for looking into it!