nlplab / brat

brat rapid annotation tool (brat) - for all your textual annotation needs
http://brat.nlplab.org
Other
1.82k stars 509 forks source link

Symmetric relations drawn with single arrowhead [again] #978

Closed spyysalo closed 11 years ago

spyysalo commented 11 years ago

Regression of #670, confirmed present in 897e74858be25948701b9e6d7d8ce7366d64cdc5 and 1.3p1.

To replicate: create annotation.conf

[entities]
Simple_chemical

[relations]
Equiv   Arg1:Simple_chemical, Arg2:Simple_chemical, <REL-TYPE>:symmetric-transitive

[events]
[attributes]

.txt

[Study of fungus polysaccharides compounds (FPC) in inducing the apoptosis of liver cancer cell Bel-7402].

.ann

T13 Simple_chemical 10 42   fungus polysaccharides compounds
T14 Simple_chemical 44 47   FPC
*   Equiv T13 T14

visual.conf (partial):

Equiv   dashArray:3-3

The expected behavior is that if arrowHead:none does not appear in visual.conf, arrowheads are drawn symmetrically on both sides for symmetric relations.

amadanmath commented 11 years ago

I don't think it was a regression - it was a consequence of Equiv's arrowHead not being defined, and the default was simply not very good.

Another problem that I have no clue how it survived so far: symmetric relations were not being discovered as symmetric, since we're looking up that information in several places and the one that doesn't have this information was coming up sooner. I knew the split between events and relations will be trouble. :)

Okay, assuming that if something is a relation it can't have meaningful info on span definitions, see if this works for you.

spyysalo commented 11 years ago

Thanks, works for me now.