Don't add "note_name" when listing notes

thomasyu888 commented 3 years ago

There are multiple things that currently happen:

Using the cli, when annotating notes: Annotation Object is returned by the client CLI and not the Text*AnnotationResponse object. code
"note_name" key is added when listing notes - this is to support annotationSource when annotating notes. code. This is done in convenience since fhir_store_id is already a parameter of list_notes

Return TextAnnotationResponse objects when annotating notes
Storing annotations would require fhir_store_id so that note_name can be generated.. It would also take as input TextAnnotationResponse objects. This creates slight confusion when saying store_annotations, because this could mean two things.
- Storing of Annotation Objects
- Storing of TextAnnotationResponse objects
- Remove "note_name" from list_notes so that notes conform to the Note schema

Thoughts @tschaffter, @cascadianblue ?

tschaffter commented 3 years ago

@tschaffter Review this ticket

tschaffter commented 3 years ago

@thomasyu888 Can you review this ticket before our meeting on Monday? Then let's review it together.

tschaffter commented 3 years ago

@thomasyu888 Is this ticket required for the launch?

thomasyu888 commented 3 years ago

@tschaffter this is not required for launch.

nlpsandbox / nlpsandbox-client