search

nlpsandbox / nlpsandbox-infra

AWS CloudFormation templates for deploying the NLP Sandbox infrastructure
Apache License 2.0
0 stars 1 forks source link

IT-1205: Add VPC #12

Closed thomasyu888 closed 3 years ago

thomasyu888 commented 3 years ago

Follow iAtlas example and adding VPC to nlpsandbox AWS account.

Depends on: https://github.com/nlpsandbox/nlpsandbox-infra/pull/13

dpulls[bot] commented 3 years ago

:warning: Dpulls not installed on repository nlpsandbox/nlpsandbox-infra. Checkout our quickstart for how to install.

zaro0508 commented 3 years ago

i think @tthyer and @BrunoGrandePhD might be interested in this PR.

tthyer commented 3 years ago

@zaro0508 why?

BrunoGrandePhD commented 3 years ago

@zaro0508: I suggested that he leveraged the CI workflows that we created for the aws-workflows-nextflow-infra repo.

@tthyer: This PR has nothing to do with Nextflow. You can disregard it.

thomasyu888 commented 3 years ago

Apologies all, I complicated things a bit by also updating the CI in the same PR. Things should be updated now. This PR has nothing to do with nextflow.

BrunoGrandePhD commented 3 years ago

I've split off the CI changes to a separate PR (#14; draft until this PR is merged). I've updated the Sage VPN table with the CIDR used in this PR.

I believe that I've addressed all of the comments so far. If there's anything left to be tweaked, let me know!

/cc @zaro0508 @ahayden

BrunoGrandePhD commented 3 years ago

@ahayden: By the way, I confirmed with @thomasyu888 that the mini VPC meets his needs with this account. I updated the Sage VPN table with the CIDR block being used in this PR.

Do you have any other concerns with this PR?