search

nlpsuge / Always-Show-Titles-In-Overview

This a Gnome Shell extension, which customizes the Overview, including always showing titles of all window thumbnails and setting the position of icons and titles, etc.
https://extensions.gnome.org/extension/1689/always-show-titles-in-overview/
GNU General Public License v3.0
21 stars 3 forks source link

#8: check if metaWorkspace is null #9

Closed herrminni closed 1 year ago

herrminni commented 2 years ago

This fixes null exception when any window is on 2nd screen

nlpsuge commented 2 years ago

Hi Michael, I pushed a fix to branch fixbug-failed-leave-overview-on-2nd-monitor, see https://github.com/nlpsuge/Always-Show-Titles-In-Overview/commit/c51a61c7276c99a577660b79f248aa4373b2e8b6 for more details.

These two fixes are a little different, I'm not sure which one is better, I don't have a second monitor to test.

Please see the gnome-shell source workspace.js. It seems that if this.metaWorkspace is null, then this workspace is the active one (the current one).

Can you please test them both.

Thank you :)

herrminni commented 2 years ago

Hi nlpsuge,

your fix here works, too! I just installed the extension with ZIP-Download from the branch fixbug-failed-leave-overview-on-2nd-monitor and can confirm I have no issue with the 2nd monitor any more.

Great, thank you!

Best regards, Michael