nlpyang / PreSumm

code for EMNLP 2019 paper Text Summarization with Pretrained Encoders
MIT License
1.29k stars 465 forks source link

A question about data_loader.py #189

Open elevenofji opened 4 years ago

elevenofji commented 4 years ago

In the "create_batches" of class DataIterator


_for buffer in self.batch_buffer(data, self.batchsize * 300):


why 300? I do think the second para should be *_self.batch_size self.args.maxpos, otherwise the definition of args.max_pos is in contradiction with the 300**

pretidav commented 2 years ago

In the "create_batches" of class DataIterator

_for buffer in self.batch_buffer(data, self.batchsize * 300):

why 300? I do think the second para should be *_self.batch_size self.args.maxpos, otherwise the definition of args.max_pos is in contradiction with the 300**

Same problem here. It's not clear where that 300 comes from. Any explanation would be very helpful!

@nlpyang