nlrb / com.visonic.powermax

Visonic PowerMax application for Homey
https://apps.athom.com/app/com.visonic.powermax
13 stars 8 forks source link

[BOUNTY] Visonic SDK v2 Compatibility Work #29

Closed konradwalsh closed 1 year ago

konradwalsh commented 5 years ago

I am hoping with this thread to provide the motivation for @nlrb to upgrade the Visonic app. He did a great job creating it. Now, it would be great for it to work with SDK v2. I have no idea how much work is involved, but without his app, my install is pretty useless with the new 2.0. Therefore, I would propose a bounty to assist him. I am offering €20 euro. If @nlrb comes back and says there is significant work then I will gladly up my bounty. Are there others willing to support this?

Bounty currently stands at

€20 - Konrad Walsh - @KonradWalsh €20 - Raymondh - @Raymond €20 - jeroenvano - @jeroenvano €20 - MarcoRuiter - @MarcoRuiter €20 - Javier - @jmieres €20 - Gr. Remco - @rhannink Total - €120

https://community.athom.com/t/bounty-20-visonic-sdk-v2-compatibility-work/5242

konradwalsh commented 5 years ago

FYI Bounty already at €60

jeroenvano commented 5 years ago

Hi Ramón - just to let you know that I am also backing this (jeroenvano). You know everyone loves your app and that is why at least some of us are willing to spend some money for your effort to upgrade to SDK2.

nlrb commented 5 years ago

Appreciate the support guys, but it is time I need :-). Hopefully I get some time to work on this during the Christmas holidays. Still rely on one of you to then test it on FW 2.0.x, since I'm not planning to move over soon.

konradwalsh commented 5 years ago

Well.. its just gone up to 80€ so you'll just have to give up on sleep!

As far as testing goes, I am in the best position now since I've just moved house and my network is broken now.

konradwalsh commented 5 years ago

€100! of faith in you

konradwalsh commented 5 years ago

120 euro!

silbernagel commented 5 years ago

@nlrb -- Is it ok to add to the bounty for purchase of another homey? I've no interest in this plugin, but if it helps the wireless weather app, I'm all in!

jwikman commented 5 years ago

@konradwalsh add another 20€ from me.

I don't need this app, but I really want an update of the wireless weather app. I'm already on FW2.0, so I live with all quirkiness right now.

If we could gather enough € to cover for a new Homey that Ramón could use for development, I assume that it's getting easier to develop apps that works on FW2.0. Don't you think @nlrb ?

nlrb commented 5 years ago

Is it important to keep 100% backward compatibility? I'm thinking of moving all separate sensors (motion, magnet, smoke, etc.) into one sensor type. It still would look the same, but is different under the hood. Advantage would be e.g. that you can pair all sensors at once from one list. Downside would be that existing sensors would need to be removed and re-paired.

konradwalsh commented 5 years ago

Either works as long as we can still individually react to each Motion sensor etc

On Sat, 29 Dec 2018, 11:33 Ramón Baas, notifications@github.com wrote:

Is it important to keep 100% backward compatibility? I'm thinking of moving all separate sensors (motion, magnet, smoke, etc.) into one sensor type. It still would look the same, but is different under the hood. Advantage would be e.g. that you can pair all sensors at once from one list. Downside would be that existing sensors would need to be removed and re-paired.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nlrb/com.visonic.powermax/issues/29#issuecomment-450486409, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoEQs4U2r628p-UPUoRn7UaEd6hqBNyks5u91MLgaJpZM4ZLKpN .

konradwalsh commented 5 years ago

Although.. For apps like heimdall having separate properly classed devices is best

On Sat, 29 Dec 2018, 11:35 Konrad Walsh, konradwalsh@gmail.com wrote:

Either works as long as we can still individually react to each Motion sensor etc

On Sat, 29 Dec 2018, 11:33 Ramón Baas, notifications@github.com wrote:

Is it important to keep 100% backward compatibility? I'm thinking of moving all separate sensors (motion, magnet, smoke, etc.) into one sensor type. It still would look the same, but is different under the hood. Advantage would be e.g. that you can pair all sensors at once from one list. Downside would be that existing sensors would need to be removed and re-paired.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nlrb/com.visonic.powermax/issues/29#issuecomment-450486409, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoEQs4U2r628p-UPUoRn7UaEd6hqBNyks5u91MLgaJpZM4ZLKpN .

silbernagel commented 5 years ago

I say you can kill backward compatibility. Some times you need to update things.

mruiter commented 5 years ago

A repair of all the devices is something youre userbase is happy to do . Good to see you found Some time . 🎉 that 20 euros are burning in my pocket 😉

rhannink commented 5 years ago

Ading all sensors Again is no problem at all. Must say, the app is working for me on 2.0 but haven’t tried removing/addding or changing something. Good to hear You found time to pick it up again.

konradwalsh commented 5 years ago

That's odd cause it doesn't work for me on 2.0

On Sat, 29 Dec 2018, 15:31 rhannink, notifications@github.com wrote:

Ading all sensors Again is no problem at all. Must say, the app is working for me on 2.0 but haven’t tried removing/addding or changing something. Good to hear You found time to pick it up again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nlrb/com.visonic.powermax/issues/29#issuecomment-450500477, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoEQtBKo21m_Rr1dni_Wm15iSEgVPikks5u94rngaJpZM4ZLKpN .

konradwalsh commented 5 years ago

Interestingly.. @rhannink comment got me thinking.. So I removed my panel from homey and readded it and yes it works.. It does give errors when saving settings but works nonetheless

konradwalsh commented 5 years ago

The biggest issue I see is that flows don't work.. Now you have to select a panel that the flow applies too

nlrb commented 5 years ago

Well, there is a new branch available. As it is a major rewrite, it still requires extensive testing though (and I'll probably do some more tweaks).

konradwalsh commented 5 years ago

Excellent...

Will start testing now

On Fri, 4 Jan 2019, 16:46 Ramón Baas, notifications@github.com wrote:

Well, there is a new branch available. As it is a major rewrite, it still requires extensive testing though (and I'll probably do some more tweaks).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nlrb/com.visonic.powermax/issues/29#issuecomment-451499020, or mute the thread https://github.com/notifications/unsubscribe-auth/AHoEQh31Eq5OE7Y3UhCQH36kLGz1NLklks5u_4VugaJpZM4ZLKpN .

konradwalsh commented 5 years ago

OK.. so no major issues.. Did re-add all devices Settings Page loads with logs visible Will start checking out flows in more detail now

konradwalsh commented 5 years ago

So I have had 3 crashes in 3 days..

Seems to happen when we set the alarm from within Homey.. there is an error regarding the Promise Response...

Otherwise.. seems reasonably stable

EDIT: I hadn't noticed you committed new versions.. I will update my installed version and report back

nlrb commented 5 years ago

@konradwalsh Indeed please update. There have been some important changes (including the Promise fix).

Javiast commented 5 years ago

Hello, I'm still in Homey FW v1.5.13. Will it help if I start testing the new SDK2 version ?

Brendvm commented 5 years ago

No rush, just curious. Is there any news to report for this app regarding homey v2? How is testing going and any chance of this app hits the app store (maybe as a beta).

mruiter commented 5 years ago

Looks 2 me everything works except one thing. The Powermax panel status changed trigger cards dont seem to work. So status has changed to Activated , Deactivated or partial activated dont seem to trigger the flows.

The status tchanged trigger card with a tag that gets filled does seem to work.

nlrb commented 5 years ago

@mruiter Thanks for testing. Can you add a screen shot of which one does not work for you? This one works for me: image

nlrb commented 5 years ago

@Brendvm I'll first need to update the docs & images before it can be submitted to the app store. But the code should be in reasonably good order now.

mruiter commented 5 years ago

Hello Ramón,

I guess its the same card but then under Homey V2

Maybee someone else can test these cards to on Homey V2 ?

These seem to be the only cards or function in the app that dont seem to be working in testing the new app for me

Verstuurd vanaf mijn iPhone

Op 13 jan. 2019 om 17:03 heeft Ramón Baas notifications@github.com het volgende geschreven:

@mruiter Thanks for testing. Can you add a screen shot of which one does not work for you? This one works for me:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

nlrb commented 5 years ago

Hi Marco, well, that explains it. That is a default capability, so I cannot fix this in the app. Probably Athom has forgotten to implement this one in v2. Wouldn’t be the first time 😄 .

mruiter commented 5 years ago

Mmm then i have to use the status changed with a and tag is i guess since thats youre code .

Would not be the first time indeed 😝

Verstuurd vanaf mijn iPhone

Op 13 jan. 2019 om 19:55 heeft Ramón Baas notifications@github.com het volgende geschreven:

Hi Marco, well, that explains it. That is a default capability, so I cannot fix this in the app. Probably Athom has forgotten to implement this one in v2. Wouldn’t be the first time 😄 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Brendvm commented 5 years ago

I am not on v2 yet, so can't tell. Soon as this app becomes officialy available i'm going to update. Thanks to @nlrb for all your time and effort.

moores211 commented 5 years ago

when i open the visonic app on the v2 homey app it just says event log - how do i add my panel? thanks all where do i send 20 euros? this is the main thing that stops me going back to vera!

mruiter commented 5 years ago

Just add a new device . Type powermax Just like how you would add a zwave hue or other device

Verstuurd vanaf mijn iPhone

Op 17 jan. 2019 om 20:16 heeft moores211 notifications@github.com het volgende geschreven:

when i open the visonic app on the v2 homey app it just says event log - how do i add my panel? thanks all where do i send 20 euros? this is the main thing that stops me going back to vera!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

rpbras commented 5 years ago

If I update to v2 do all my flows with the Visonic app still work?

nlrb commented 5 years ago

@rpbras No. You will need to add new sensors and remove the old ones. Flows with sensors will need to be repaired.

rpbras commented 5 years ago

@rpbras No. You will need to add new sensors and remove the old ones. Flows with sensors will need to be repaired.

Ok, thnx. And thnx for rewriting the app. How can I sent you the 20 euro?

Kind regards, Raymond

nlrb commented 5 years ago

There will be a donate button on the app page.

rpbras commented 5 years ago

How many of you already changed over to Homey v2 and used the Visonic app? And what are your experiences?

rhannink commented 5 years ago

I am using Homey 2.0 but still with the old app. I have read that the change status card is not working yet. And thats what I am using in flows. ....

mruiter commented 5 years ago

You can just use the state change cards with a tag . Only the native homey cards dont work but the developer Made his own cards . He already knew Athom usualy drivers half broken goods ;)

Verstuurd vanaf mijn iPhone

Op 22 jan. 2019 om 21:03 heeft rhannink notifications@github.com het volgende geschreven:

I am using Homey 2.0 but still with the old app. I have read that the change status card is not working yet. And thats what I am using in flows. ....

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

rpbras commented 5 years ago

I thought the old app didn’t work on v2?

rhannink commented 5 years ago

You cant change any setting. But everything else is working...

rhannink commented 5 years ago

I just installed the v2.0.0 version, everything seems okay, I have made a pull request for the missing icons in the panel. I use flows with labels and they work fine. I did not have to re-add the panel, just the sensors.......

Can I already donate as promised?

mruiter commented 5 years ago

Are you sure you are using the master master code and not a second later added installer code ? The second added master code doesn’t allow you to save alarm settings from serial and gives a error . I think you are trying to give homey the right to disarm the system ?

Verstuurd vanaf mijn iPhone

Op 23 jan. 2019 om 16:25 heeft rhannink notifications@github.com het volgende geschreven:

I just installed the v2.0.0 version, everything seems okay, I have made a pull request for the missing icons in the panel. I use flows with labels and they work fine. I did not have to re-add the panel, just the sensors.......

Can I already donate as promised?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

rhannink commented 5 years ago

Yep, I am sure I use the correct master code. I get an unknown error every time I try to save the advanced settings. I did not add the panel with the new app, only the sensors...Might this have something to do with it ?

nlrb commented 5 years ago

@rhannink The panel device has not changed. So this should still work as before (it does for me). Can you attach a screenshot of the error you get? Do the run the app with run and see any logging?

rhannink commented 5 years ago

This I the error I get:

img_4040

The log file shows no entries after trying to save.

rhannink commented 5 years ago

@nlrb I ran the app from the command line with atom app run. I saw a lot off debug coming by. No errors, everything looks alright. When I set the mastercode and I save it, I get the red error in the app, but absolutely noting in the debug log on my computer. So it looks like a local app problem. Nothing is sent to the Powermax and the PowerMax does not generate any errors at the moment I press save.

Is it correct that after entering the master code you use the arrow back < and then press save?

I am 100% sure the master code is the correct one. Also tried reinstalling the app, same problem.

konradwalsh commented 5 years ago

I had an issue with a voice command that caused the app the crash repeatedly and then homey to restart...

I believe it's more to do with voice than the app..

Nonetheless there is a screenshot I caught screenshot_20190124-221340_homey

rpbras commented 5 years ago

I'm using the 'old' app under Homey v2. Everything is working as it should. Saving changed settings (inschakelen zonder uitschakelen turned on) created an error while saving (the red error), but the settings were saved which I can see when activating the alarm. It's now always 'directe inschakeling'.