nlrb / com.visonic.powermax

Visonic PowerMax application for Homey
https://apps.athom.com/app/com.visonic.powermax
13 stars 8 forks source link

sdk3 wip #47

Open phict opened 1 year ago

phict commented 1 year ago
phict commented 1 year ago

@nlrb branched from sdk2 and pr against master

luccie007 commented 1 year ago

I think you have to change something about the version numbering you entered.

As the current version found in appstore is already 2.0.4 Or are your creating the inbetween versions to complete the backlog and add functions that way (im not a programmer so i dont understand most of the code)

2.0.4 30 dec. 2019 Update sensor table & recognition 2.0.3 24 nov. 2019 Supports SDK v2 1.2.0 12 nov. 2019

phict commented 1 year ago

@luccie007 yes, named it wip since its not finished.

My first plan was just to use it myself on the new homey 2023 (only support sdk3) and just needed it to work with my setup.

Didnt get a reply on my issue in the orignal repo about upgrad to sdk 3 but thought maybe the developer could use it if he decides to release a new version for the new homey, and make final adjustements to get everything 100% before release.

phgmhendrix commented 1 year ago

Please let me know if I can be of assistance with some sort of testing when my new Homey Pro 2023 arrives. I am happy to help.

phgmhendrix commented 1 year ago

hi @phict , is this sdk3 branch working for you?

phict commented 1 year ago

@phgmhendrix i think so, haven't started using it on the old homey, waiting to get the new next week. Will try when I have time to migrate and then fix if any issues.

phgmhendrix commented 1 year ago

@phgmhendrix i think so, haven't started using it on the old homey, waiting to get the new next week. Will try when I have time to migrate and then fix if any issues.

I installed mine today and will try to test this branche.

phgmhendrix commented 1 year ago

@phict , are you Dutch and is there a way we could have contact directly... via LinkedIn or WhatsApp or whatever? Then we can make sure this app gets updated as fast as possible. I also have contact with @nlrb and if we prepare it properly I am sure het will accept the pull-request and update the application.

phgmhendrix commented 1 year ago

Currently the app crashes on the Pro 23. Let me see if I can debug it... have to find my way still 😄

phict commented 1 year ago

@phgmhendrix Sure, send me you WhatsApp and i add you

phgmhendrix commented 1 year ago

@phgmhendrix Sure, send me you WhatsApp and i add you

@phict, and how do I send it to you without publishing my mobile number on this page?

phgmhendrix commented 1 year ago

In one way or the other I cannot seem to get your changes or find the proper branch on Github... I must be doing something wrong. Debugging says: "Wrong sdk version: 2.0"

phict commented 1 year ago

@phgmhendrix send WhatsApp to homeyvisionic@mailinator.com and i remove it directly

yvoren commented 1 year ago

Hi Peter, Ramon,

is there a possible timeframe when sdk3 for the visonic powermax come's available for the Homey pro 23 ? is there already one for testing ?

phgmhendrix commented 1 year ago

Hi Peter, Ramon,

is there a possible timeframe when sdk3 for the visonic powermax come's available for the Homey pro 23 ? is there already one for testing ?

We are working on it. In the basis it works, however there is are also still some basic issues we have to address. As soon as there is a testversion, I am sure @nlrb will post it here on github. Since @nlrb is the owner, I cannot give any timeframes.