nls1729 / acme-code

Gnome Shell Extensions etc...

https://nls1729.github.io

GNU General Public License v2.0

66 stars 25 forks source link

Added scaling of the icon. #31

Closed dgmurx closed 6 years ago

dgmurx commented 6 years ago

I added the option to scale the icon. Could you check if it works for you, too, please? Thanks!

nls1729 commented 6 years ago

I did not get a notification of your merge request. I have changed my email I use on github. Hopefully this won't happen again. As fate would have it, I am very busy at this time. I looked at your code. I will try to find time in the next few days to test it. Sorry about not seeing you request...

dgmurx commented 6 years ago

On the spur of the moment I commited without testing and of course did a mistake in the fr.po file. Shall I open a new pull request or do you want to just change line 46 from msgid "Select Icon" to msgid "Scale Icon" Thank you too for your time and sorry for my sloppiness.

nls1729 commented 6 years ago

I missed the duplicate "Select Icon" message id. I have corrected in my local repo and will push it to github.

po/fr.po:46: duplicate message definition... po/fr.po:43: ...this is the location of the first definition

: prefs.js:22

-msgid "Select Icon" +msgid "Scale Icon" msgstr "Redimensionner icône"

You may want to make the change in your repo.

I will upload a zip file to extensions.gnome.org today. The review queue there is very long. It will probably be a long time before the new version will be available on the ego website.