search

nls1729 / acme-code

Gnome Shell Extensions etc...
https://nls1729.github.io
GNU General Public License v2.0
66 stars 25 forks source link

extension-reloader fix class names #42

Closed rmader closed 6 years ago

rmader commented 6 years ago

Hi there, I'm currently testing this extension on gnome 3.29.92, but this extension makes it crash (see https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/153#4137bbb5ac9)

With this changes, it works again

Edit: might also get fixed implicitly by https://gitlab.gnome.org/GNOME/gjs/merge_requests/229

nls1729 commented 6 years ago

Thanks for your fix.

nls1729 commented 6 years ago

FYI - extension-reloader has limitations that limit it usefulness. acme-code closed issue #27 gives details. The extension is only useful for working on an extension that errors and does not load. If the extension is not in the error state reloading does not load the extension from disk. Changes to the extension code on disk are not loaded if the extension is "reloaded" when not in the error state. The problem is with the gnome-shell see: https://bugzilla.gnome.org/show_bug.cgi?id=782187 and https://nls1729.github.io/extension-reloader.html (Limitations).

rmader commented 6 years ago

Thanks for the fast reply :) Yeah I now, still I like it for that matter. The extension still helped me quite a lot in debugging some extensions. For the rest, we probably have to wait for gnome-shell 4