nls1729 / acme-code

Gnome Shell Extensions etc...
https://nls1729.github.io
GNU General Public License v2.0
66 stars 25 forks source link

GNOME 3.36 compatibility for activities-config #70

Closed v4rakh closed 4 years ago

v4rakh commented 4 years ago

Hi,

thanks for writing this extension. I think we'd gladly appreciate an updated version which works with the latest GNOME 3.36 release.

nls1729 commented 4 years ago

I am working on it. What linux distribution are you using?

v4rakh commented 4 years ago

I am using ArchLinux (btw ^^).

nls1729 commented 4 years ago

I think I can have the extension in working order by the weekend. Would like a pre-release version to test?

xTeixeira commented 4 years ago

If you need anyone to test it I can help.

v4rakh commented 4 years ago

@nls1729 Sure, I'd volunteer for that. :+1:

nls1729 commented 4 years ago

There were major changes to the extension. This version of the extension will only work with GS 3.36 (and hopefully later versions.)

I have uploaded a sha256sum check sum file named CHECKSUM and a zipfile named activities-config-20072142947 @ nls1729.zip. space@space to prevent this site from making a link out of the filename... The files are on my Google Drive. You can download the files with the tiny url links:

A Download button is at the top right side of the webpage.

https://tinyurl.com/checksum-for-zipfile

https://tinyurl.com/zipfile-activities-config

You may see a Woops on the zipfile. It's not a problem.

$ cd Downloads $ sha256sum -c CHECKSUM activities-config-20072142947 @ nls1729.zip: OK Install in directory ~/.local/share/gnome-shell/extensions/activities-config@nls1729 If old extension files are there remove them.

$ cd ~/.local/share/gnome-shell/extensions/activities-config@nls1729

Be sure you are WHERE you should be before you do the remove. $ pwd /home/boogieman/.local/share/gnome-shell/extensions/activities-config@nls1729

$ rm -rf * $ ls $ unzip ~/Downloads/activities-config-20072142947@nls1729.zip

Log out and login.

You should have an installed extension to test. Let me know how it goes.

Thanks for your help.

xTeixeira commented 4 years ago

All the features and configs I use are now working fine.

I tested a few other features and I found enabling icon + activities text results in a visual glitch (I also tested with default shell theme and it's the same): Screenshot from 2020-03-13 17-45-28

Other than that it seems fine to me.

nls1729 commented 4 years ago

@xTeixeira I missed a needed alignment. In my testing I used a larger font that hid the problem. When I set the font to the normal size it was very obvious something was wrong. All centered now. Thanks.

v4rakh commented 4 years ago

Is there a reason why we cannot build from a separate git branch? Would be easier and you could also reference this issue then. I am asking because I don't see any changes in the git repository for it. :-)

I tested your provided file and it seems to work fine for my configuration. Thanks for your work. I guess with two confirmations you might be confident enough to release this as a 3.36 only version on extensions.gnome.org?

nls1729 commented 4 years ago

@v4rakh I don't push branches to Github. I use branches locally. When I complete a new version of an extension I submit it to extensions.gnome.org. When ego accepts the extension it becomes available on the ego website with a new "official" version number. I then merge the local branch and push master to Github. Some linux distributions use ego as an upstream source of extensions. Fedora provides an optional package of the Activities Configurator as a "system" extension which is installed in /usr/share/gnome-shell/extensions. I think Arch linux actually repackages an Arch branded version of the Activities Configurator. I have had problems in the past where an extension would get "modified" and then go a website as "freeware". A freeware user would want me to fix their freeware. I have a simple answer to those requests. Go to the ego website and install the official version. I do accept bug fixes and enhancements from Github users who fork my repo and submit a merge request. And finally to maintain the extension creation process I have a some ugly tools that are needed to create the finished zip file of an extension. Take a look at the Makefile for the Activities Configurator. It uses a lot of resources that I don't push to Github and aren't in my local git repository. If I were working as one developer in a group those tools would likely be maintained by one of the developers for use by the group. In the early days of the Gnome Shell with the advent of shell extensions it was discussed how extensions should be handled. Since an extension is actually a patch to the shell itself it was accepted a member of the Gnome group should review all extensions before being released to the general public. I agree with the need for review. Before it is released to everyone my extensions get reviewed. Sorry for the long winded response but it is kind of complicated.

v4rakh commented 4 years ago

If one likes to contribute, that's more difficult then without knowing your real current state, but your decision anyway. 👍

Will you publish the extension soon on ego? I'd close this issue then.

nls1729 commented 4 years ago

Yes, I will upload later today. Please leave this issue open. Usually it takes a few days for the review to complete. Leave the issue open. When the extension is available on ego I will close the issue.

nls1729 commented 4 years ago

Version 80 for GS 3.36 : https://extensions.gnome.org/extension/358/activities-configurator/