Closed kloczek closed 1 year ago
Thanks for the NetworkManager-pptp issue link. For consistency, I'll wait and do whatever NetworkManager-pptp does for the fix.
I suspect they are taking their time with the upstream NetworkManager VPN clients to build in a gtk4 only build env because almost all Linux distros still ship with the gtk3 based nm-connection-editor
which is part of the network-manager-applet source :
The non-libnma parts of network-manager-applet (i.e. applet and editor) have not been ported to gtk4. I guess once nm-connection-editor
has been ported to gtk4, they'll update the NetworkManager VPN clients to allow building in a gtk4 only build env.
I'm still keeping an eye out on the upstream NetworkManager VPN clients, once any of them support a gtk4 only build env, I'll do the same as whatever they do.
Any update? 🤔
I haven't seen any upstream changes yet.
I noticed the corresponding NetworkManager-pptp issue #6 was closed with the following message :
This works as intended -- the gtk3 build is enabled by default.
You need to pass
--without-gnome
toconfigure
to disable it.
in the configure.ac
code I see:
if test x"$with_gnome" != xno; then
PKG_CHECK_MODULES(GTK, gtk+-3.0 >= 3.16)
GTK_CFLAGS="$GTK_CFLAGS -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_16"
GTK_CFLAGS="$GTK_CFLAGS -DGDK_VERSION_MAX_ALLOWED=GDK_VERSION_3_16"
PKG_CHECK_MODULES(LIBNMA, libnma >= 1.8.0)
PKG_CHECK_MODULES(LIBSECRET, libsecret-1 >= 0.18)
fi
if test x"$with_gtk4" != xno; then
PKG_CHECK_MODULES(GTK4, gtk4 >= 4.0)
GTK4_CFLAGS="$GTK4_CFLAGS -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_4_0"
GTK4_CFLAGS="$GTK4_CFLAGS -DGDK_VERSION_MAX_ALLOWED=GDK_VERSION_4_0"
PKG_CHECK_MODULES(LIBNMA_GTK4, libnma-gtk4 >= 1.8.33)
fi
I suspect the PKG_CHECK_MODULES(LIBSECRET, libsecret-1 >= 0.18)
package check should still be performed when --without-gnome
and --with-gtk4
are used.
I'll close this as the corresponding NetworkManager-pptp issue #6 was closed.
Would have preferred that they were more consistent in the naming of the flags between gtk3 and gtk4, but will stick to whatever upstream NetworkManager project does.
Yeah looks like it is the same issue like in https://gitlab.gnome.org/GNOME/NetworkManager-pptp/-/issues/6