search

nm-l2tp / NetworkManager-l2tp

L2TP and L2TP/IPsec support for NetworkManager
GNU General Public License v2.0
493 stars 83 forks source link

Removed the GATEWAY_ID from the ipsec.secrets file as it did not work #21

Closed mmattes closed 8 years ago

mmattes commented 8 years ago

with strongswan for me.

The generated ipsec.secrets looked like this but strongswan could not connect like this. %any @192.168.90.1 : PSK "MYSECRET"

the ipsec.secrets file like this worked for me: %any : PSK "MYSECRET"

May this helps...

dkosovic commented 8 years ago

I've just got to do a bit of research before accepting this pull request to make sure there isn't some obscure reason why the second argument before the colon was in there in the first place, but pretty sure your solution will be fine.

If there is some obscure reason, I'll fix the code so that ipsec.secrets becomes : %any 192.168.90.1 : PSK "MYSECRET"

I have some exisiting code elsewhere to not include the @ prefix for an ID that is an IP address

mmattes commented 8 years ago

Im sorry but I cant confirm that the following will work. %any 192.168.90.1 : PSK "MYSECRET"

only the combinations worked for me %any : PSK "MYSECRET" %any %any : PSK "MYSECRET"

I have also tried this which comes from the bottom here from here but it did not work %any ipv4:#0a000001 : PSK "MYSECRET"

mmattes commented 8 years ago

i hope these changes make more sense

dkosovic commented 8 years ago

Sorry for my tardiness, been away from home. I was happy with your original pull request as that's what I normally do when I manually setup a ipsec.secrets file for both strongSwan and Libreswan, I was probably just being a bit overcautious.

I'll be working on the code over the weekend to finish off a few things in preparation for the next release. Will most likely merge the pull request tomorrow when I'm less tired and want to do a better check.