pppd keeps running after disconnect

nm-l2tp / NetworkManager-l2tp

L2TP and L2TP/IPsec support for NetworkManager

GNU General Public License v2.0

488 stars 84 forks source link

pppd keeps running after disconnect #39

Closed fnordahl closed 7 years ago

fnordahl commented 7 years ago

I am running on Ubuntu 16.04 LTS.

After disconnecting a L2TP/IPSec VPN connection using the NetworkManager Gnome applet in the top menu bar, I can see that the pppd process is not being killed and I have to kill it manually.

dkosovic commented 7 years ago

Just pppd or both pppd and its parent xl2tpd process ?

fnordahl commented 7 years ago

Just pppd.

$ ps axuw | egrep "pppd|xl2tpd"
root     18553  0.0  0.0 209520  6308 ?        Sl   07:43   0:00 /usr/sbin/pppd passive nodetach : file /var/run/nm-ppp-options.xl2tpd.18465 plugin pppol2tp.so pppol2tp 7

dkosovic commented 7 years ago

I'm pretty sure it is related to https://github.com/nm-l2tp/network-manager-l2tp/issues/38#issuecomment-288434451 where Ubuntu's xl2tpd crashes before it has had a chance to reap its child pppd process.

fnordahl commented 7 years ago

Ah, of course. I think you are right. I have observed xl2tpd die with SEGFAULT.

I will make an attempt at debugging the crash tomorrow.

fnordahl commented 7 years ago

https://bugs.launchpad.net/ubuntu/+source/xl2tpd/+bug/1677990

fnordahl commented 7 years ago

Please do help confirm the bug in launchpad by clicking "this bug affects me" @dkosovic @mgedmin

fnordahl commented 7 years ago

This should now be fixed in Ubuntu Xenial 16.04 LTS and Ubuntu Yakkety 16.10. The version of xl2tpd shipped with Ubuntu Zesty 17.04 and Ubuntu Artful Advark 17.10 already included the upstream fix and was never affected.

dkosovic commented 7 years ago

That's awesome news! I'll update the xenial and yakkety network-manager-l2tpd PPA packages by putting explicit dependencies for xl2tpd >= these updated revisions.

I've uploaded a Debian Sid package to :

https://mentors.debian.net/package/network-manager-l2tp

and requested sponsorship on the pkg-utopia-maintainers@lists.alioth.debian.org mailing list (as Utopia package the similar network-manager-pptp package). Hopefully I'll find a sponsor, once it is in Debian, I'll put a sync request in for Ubuntu and mention the xenial and yakkety specific depedencies for xl2tpd and strongswan.