rpmlint warning dbus-policy-allow-without-destination

[vyskocilm]

This limits messages with interface org.freedesktop.NetworkManager.l2tp.ppp to be sent only to dbus-policy-allow-without-destination.

This is untested change, but may work. Reference:

• https://lintian.debian.org/tags/dbus-policy-without-send-destination.html
• https://github.com/mate-desktop/mate-applets/issues/46

[dkosovic]

The patch seems semantically the same, but syntactically a bit different. I wonder if it is a false positive for the version of rpmlint you are using?

In the Debian Lintian 2.5.52 report for this package, I don't see the dbus-policy-allow-without-destination warning, but do see others : https://lintian.debian.org/full/doug@uq.edu.au.html

Similarly with Fedora, but the "Automated Tests" report doesn't seem to be working at the moment :

• https://bodhi.fedoraproject.org/updates/FEDORA-2017-9a30cd7fde

On which Linux distribution and version are you seeing this rpmlint warning?

[dkosovic]

Forgot to mention, I track the changes to NetworkManager-pptp from the GNOME Project and port them back to NetworkManager-l2tp , in particular nm-l2tp-service.conf is currently identical to nm-pptp-service.conf, apart from all instances of 'pptp' being replaced with 'l2tp' : https://git.gnome.org/browse/network-manager-pptp/tree/nm-pptp-service.conf

If you think this rpmlint warning is an issue, I'm happy to report it upstream to GNOME Bugzilla for NetworkManager-pptp and see what they have to say.

[vyskocilm]

This is indeed strange - I got this rpmlint warning when doing build for openSUSE Tumbleweed. However looking at https://github.com/GNOME/network-manager-pptp/blob/master/nm-pptp-service.conf and https://build.opensuse.org/package/show/GNOME:Factory/NetworkManager-pptp it looks like in this case file works well. So I am closing my PR.