search

nm-l2tp / NetworkManager-l2tp

L2TP and L2TP/IPsec support for NetworkManager
GNU General Public License v2.0
493 stars 83 forks source link

Don't require a password when authentication with certificates #7

Closed frenetic1 closed 7 years ago

frenetic1 commented 8 years ago

Hi,

can you apply this patch: https://github.com/seriyps/NetworkManager-l2tp/issues/44

thx

dkosovic commented 8 years ago

I've applied patch to the nm-1-0 branch.

Unfortunately for the master branch, the code has changed considerably after commit https://github.com/nm-l2tp/network-manager-l2tp/commit/66a5355c971a77aaa7b06540025521084116609a which used NetworkManager-pptp 1.2.2's nm-pptp-service code and retrofitted the L2TP/IPSec code. The certificate code hadn't been retrofitted due to the considerable number of changes and I wasn't able to test.

frenetic1 commented 8 years ago

Thanks! Maybe I try to take a look at it in the next weeks. Do you already know which change causes a lot of work on retrofitting the cert code?

dkosovic commented 8 years ago

It's not so much about causing a lot of work to retrofit, but needing to be able to test. Lots of code has moved around and some of the credential handling code has changed or been removed, so if I added the cert code myself, chance are it would be broken as I'm not able to test.

note: nm-1-0 branch is intended for NetworkManger 1.0 (and 0.9) based linux distributions, while the master branch is for NetworkManger 1.2 (and 1.1) based linux distributions.

dkosovic commented 7 years ago

I'm closing this issue for the time being.

There has since been a new release (version 1.2.4).

If you wish to re-open, reply with any changes.