search

nm-l2tp / NetworkManager-l2tp

L2TP and L2TP/IPsec support for NetworkManager
GNU General Public License v2.0
486 stars 84 forks source link

properties: don't assume the error argument is present #87

Closed lkundrak closed 6 years ago

lkundrak commented 6 years ago

It's customary to allow NULL error when the caller decides to ignore an error condition (and it may actually choose to do so, in which case this will dereference a NULL pointer).

dkosovic commented 6 years ago

I also cherry picked the commit to the nm-1-2 branch and will probably release a new NetworkManager-l2tp 1.2.12 release in the next few weeks.

A NetworkManager-l2tp-1.8.x release from the master branch (which uses the NMACertChooser for both IPsec and L2TP) is a while away. I thought I could get away with using NSS exclusively, but NSS couldn't do everything I needed, so I've started using OpenSSL, but been dragging my feet waiting for the OpenSSL license change before doing too much work or committing anything for nm-l2tp-service.