search

nm-l2tp / NetworkManager-l2tp

L2TP and L2TP/IPsec support for NetworkManager
GNU General Public License v2.0
486 stars 84 forks source link

nm-shared-utils.c requires GNOME/network-manager-applet when building --without-gnome #89

Closed kwhat closed 5 years ago

kwhat commented 5 years ago

Hi,

When compiling the latest .10 revision using --without-gnome, the build fails to complete due to https://github.com/GNOME/network-manager-applet/blob/master/src/libnma/nma-ui-utils.h dependency. I would assume this should not be needed unless compiled --with-gnome?

Thanks

dkosovic commented 5 years ago

Can you confirm if you have the issue if you use the same configure switches and try to compile the GNOME Project's NetworkManager-pptp ?

The reason I ask is that this VPN client was ported from NetworkManager-pptp and I often re-sync with it. If it is a problem there, then it should be reported upstream to the GNOME Project so they can fix it for all of their VPN clients.

dkosovic commented 5 years ago

Thanks for the bug report.

A fix has now been committed and I will also report the bug upstream to the GNOME Project as NetworkManager-pptp is also affected.

kwhat commented 5 years ago

Hi thank you, I tested with pptp and I did not originally have it installed. After testing same result as before. Thank you for the fast turn around.

dkosovic commented 5 years ago

According to upstream :

the following part of the patch was not entirely right:

+if WITH_GNOME
 plugin_LTLIBRARIES += properties/libnm-vpn-plugin-l2tp.la
+endif

libnm-vpn-plugin-l2tp is the core part of the plugin. It has no GTK (Gnome) dependencies. It can always be built as it has no dependencies that wouldn't be satisfied already.

fixed with commit https://github.com/nm-l2tp/network-manager-l2tp/commit/393562f13136aea252e4f5f98fe441d4ed0d1b74