Resources not closed in setRevisionTextAndParts

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Just use the revision iterator with shouldLoadRevisionText = true.

What is the expected output? What do you see instead?
After processing ~2.500.000 revisions, my program slowly started to die. Did 
some profiling and found out that in the setRevisionTextAndParts method of the 
RevisionApi class, the PreparedStatement and the ResultSet are set twice, 
without closing them in between.

What version of the product are you using? On what operating system?
0.9.2, Ubuntu 12.04.

Please provide any additional information below.
Made a simple fix for this and confirmed through profiling that the objects are 
now properly cleaned up.

Original issue reported on code.google.com by ljtijh...@gmail.com on 21 Aug 2013 at 10:05

[GoogleCodeExporter]

Could you please provide the fix that solves the issue. Thanks.

Original comment by torsten....@gmail.com on 30 Aug 2013 at 12:46

• Changed state: Accepted

[GoogleCodeExporter]

The attached version contains the fix. Just an extra pair of try/finally 
brackets and closing the statement and result.

Original comment by ljtijh...@gmail.com on 30 Aug 2013 at 12:56

Attachments:

• RevisionApi.java

[GoogleCodeExporter]

Thanks, fixed in latest snapshot.

Original comment by torsten....@gmail.com on 30 Aug 2013 at 12:59

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by oliver.ferschke on 11 Sep 2014 at 1:35

• Added labels: Milestone-Release-0.10.0

[GoogleCodeExporter]

Original comment by oliver.ferschke on 11 Sep 2014 at 1:36

• Added labels: Milestone-Release-1.0
• Removed labels: Milestone-Release-0.10.0