Fan control should be reset to "automatic" when script receives SIGTERM

nmaggioni / r710-fan-controller

A Python script and SystemD service to control Dell PowerEdges' fans depending on CPU(s) temperatures.

MIT License

140 stars 39 forks source link

Fan control should be reset to "automatic" when script receives SIGTERM #5

Closed FlorianZ closed 4 years ago

FlorianZ commented 4 years ago

Currently, when stopping the systemd service fan control remains in whatever mode the script was last in. If this is "manual" mode, and the fans are running at at low RPM, CPU temperatures may reach critical levels during boot / inside BIOS, where low-power states are not maintained. The script should probably make a best effort to return to "automatic" mode when it exits.

I can submit a PR when I get a chance, just logging this for the time being. Thank you!

nmaggioni commented 4 years ago

Good idea, may be useful in some setups even though I don't see it working reliably 100% of the time unfortunately: if the script is stopping, chances are that the main or remote systems are already halting and thus might not behave as expected.

In absence of PRs I might implement this soon anyway, thanks for the heads up.