Implement routine left@CONTROLLER_2048

[nricci]

Routine left in class CONTROLLER_2048 is not implemented. This routine must be implemented, possibly equipped with a corresponding contract (pre and postcondition). This issue also includes the definition of tests to exercise this routine, that must comply with statement coverage.

Auxiliary routines, if necessary, must be private. Tests must be given clear names that illustrate what is being measured. Tests for this routine must be put into folder/cluster tests/controller_2048/left_at_controller_2048.e

[fedebono]

the tests are indexed from 0 to 3 or 1 to 4?

[fedebono]

No class allows me to upload

[fedebono]

I can not resolve these errors Error code: VEVI

Error: variable is not properly set. What to do: ensure the variable is properly set by the corresponding setter instruction.

Class: APPLICATION Source class: EV_ANY Feature: default_create Creation procedure: make_and_launch declared in APPLICATION Attribute(s): first_window Line: 63 implementation.set_state_flag ({EV_ANY_I}.interface_default_create_called_flag, True) -> implementation.assign_interface (Current) initialize

[fedebono]

Error code: VEVI

Error: variable is not properly set. What to do: ensure the variable is properly set by the corresponding setter instruction.

Class: ABOUT_DIALOG Source class: EV_ANY Feature: default_create Attribute(s): pixmap, message_label Line: 63 implementation.set_state_flag ({EV_ANY_I}.interface_default_create_called_flag, True) -> implementation.assign_interface (Current) initialize

[nmaguirre]

I don't understand your comments. set_state_flag is not part of what we are solving here. We are not using EiffelVision, so EV_ANY_I is not reachable with our project settings. Please be more precise about your problem, and what is its relevance with respect to the current project (and your issue).

[nmaguirre]

Your implementation is too late already. Please resolve your issue as soon as possible. You have time until Monday (September 8). If your issue is not resolved by Monday, it will be reassigned to another developer. If you have problems, please contact the managers in class, through Moodle, or ask questions / raise issues through github.

Your deadline for resolving this issue is Monday. Please solve the problem.

[jjaimez]

Test Left_at_controller_2048 not compile. Syntax error at line 5.

Controller_2048 not compile. Syntax error at line 268.

[ggiovannini]

Solved in commit 2440937ad2eba85023aa990d5349583af2cecf89 and 43f9914bf5f4b3507b01ab3e15f05bbc9c3a3cde

[rdegiovanni]

well done!

[rdegiovanni]

Sorry, there is just a minor error in your test's names. For example, in the test_movs_left3, change the word movs for move.

[ggiovannini]

Solved in commit b85d99c8c1168d25e16d8cba1f6abe1e6e0fe8c4

[rdegiovanni]

well done!

[rdegiovanni]

There is the same error in the test's name in the class LEFT_AT_BOARD_2048 in the branch client_server. For example, in the test_movs_left3, change the word movs for move. Please, solve this issue and do the commit in the client_server branch.

[ggiovannini]

At commit b85d99c8c1168d25e16d8cba1f6abe1e6e0fe8c4 were already made ​​those changes. Looks like someone put an old version. Now I will make those changes again.

In commit a81dad2626d0abafd5ebfb940e7b6bef5327ff29 are the new changes

[nmaguirre]

Remove routine left. Make sure all calls to this routine are moved to the corresponding routine in controller.board.

[ggiovannini]

This issue is not equal to https://github.com/nmaguirre/eiffel-2048/issues/199 ???