search

nmaguirre / eiffel-subtitle-converter

A Subtitle Converter developed in Eiffel using Design by Contract
MIT License
3 stars 2 forks source link

Missing precondition for routine adjust_start_time.SUBRIP_SUBTITLE_ITEM #90

Open arangue opened 9 years ago

nricci commented 9 years ago

You can't mark as resolved without supplying a rev. nro.

fedebono commented 9 years ago

solved in rev. e4fb512

saiema commented 9 years ago

The preconditions you wrote will always be true since the argument of the feature is not defined as detachable. You should make a more appropriate precondition.

fedebono commented 9 years ago

solved in rev. 6dd6a34

saiema commented 9 years ago

The precondition is wrong, this case proves it:

{01:00:00:0000} > {00:00:00:1000}

but your precondition will compare 0000 < 1000