search

nmaguirre / minesweeper

A Simple MineSweeper Project
6 stars 4 forks source link

Remove exception thrown from MinesweeperBoard#isValidIndex(int,int) #104

Closed nricci closed 8 years ago

nricci commented 8 years ago

MinesweeperBoard#isValidIndex(int,int) should only return a boolean value, instead this method throws an exception, fix this.

orevitnoonairam commented 8 years ago

Resolve in bf190d6

nricci commented 8 years ago

@orevitnoonairam: the commit you supplied shows changes other than the ones described by the issue

orevitnoonairam commented 8 years ago

@nricci I noticed that the name was changed to isValidCordenate, and rename it isValidCoordinate. Also noticed that @elnano10 was modifying the same method. Should mark this issue as duplicate?

nricci commented 8 years ago

Yes, you are right. I misread it and didn't notice you refactored the method name. You should if both issues are dating with the same problem. What's the issue number?

orevitnoonairam commented 8 years ago

@nricci #59. Supposedly this issue was responsible for correct the 59.

nricci commented 8 years ago

59 is older than this issue, and also slightly different, so there is no problem.