search

nmaguirre / minesweeper

A Simple MineSweeper Project
6 stars 4 forks source link

MinesweeperBoard.isValidIndex has no test #73

Closed gamassimino closed 8 years ago

gamassimino commented 8 years ago

solved in this rev 780bcbb

nricci commented 8 years ago

Well done

nricci commented 8 years ago

You have tested that the method returns true when it should. Provide more cases to test the opposite: that it will return false when given invalid indexes.

nricci commented 8 years ago

Also keep in mind that the method has been renamed (see issue #97). Rename your test accordingly.

gamassimino commented 8 years ago

fix 6719272

elisaboselli commented 8 years ago

well done :+1: