Open aindriu80 opened 6 years ago
This addons seems basically abandoned (e.g. https://github.com/nmaier/mintrayr/pull/179 still not merged). I think we need a community fork.
MinimizeToTray revived revived.
E: Last commit over 2 years ago: https://github.com/nmaier/mintrayr/commits/master. Tried some tray apps, but none seemed to work.
In case anyone is considering a fork or devoting some time into making just any tray add-on for Thunderbird 60+ work again, I am hereby cross-referencing FireTray issue 238.
It doesn't work even if you set extensions.strictCompatibility=false.
My requirement is to not close the application when I click the close button (accidentally); I don't care about use tray icon or normal taskbar icon. My quick & dirty hack (I use KDE) is to remove the title bar for Thunderbird windows. https://www.reddit.com/r/kde/comments/6lwc1y/remove_titlebar/
Someone posted a working version of Firetray: https://github.com/foudfou/FireTray/issues/238#issuecomment-419705792
Hi, I worked for a lot of hours to try to run this addon on Thunderbird 60.
Here is my repository: mintrayr: dev_thunderbird_60 + branch.
And the page on AMO, waiting for validation (hoping that it will be done quickly): https://addons.thunderbird.net/en-US/thunderbird/addon/minimizetotray-reanimated/ .
Can people test if my changes are working on all systems?
Tested on Thunderbird 60.0 (Windows 10) and tray icon will not appear. Settings works but have no effect. Thunderbird logs contains following:
@kolinger : Okay, thank you for testing, I do not have a computer under Windows at hand.
This goes back to what you said a few days ago on another post, the lack of unpacking of the application poses big problems with js-ctypes.
Hi ysard. Tested on Gentoo / Fluxbox / Thunderbird 60.0 but no tray icon appears. The settings do not open either, throwing the error "No chrome package registered for chrome://mintrayr/content/prefs/prefs.xul". For reference I have been using FireTray [1] instead which is working.
Thanks for your work.
[1] https://github.com/firetray-updates/FireTray/tree/thunderbird-57
@ysard Linux is different in this matter? This extension is using ctypes for linux too if I see correctly.
@lbratch Where is working version for download? I tried compile repository what did you sent. Resulting extension will install but settings nor tray icon works. Settings are broken and icon will not appear. I'm missing something?
@kolinger : There may be a problem in the path that refers to the library to load (Windows folder separators are different from those used on Linux).
@lbratch : Ok thanks, this is more problematic...
I'm going to watch this tonight.
@ysard Thanks for the fork! are you planning on just making the addon work or also add new features?If it is the latter maybe the most commented feature requests could be reopened in your tracker.
Someone opened a ticket on bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1486221 perhaps people interested could comment and add their vote to it?
@WPFilmmaker Unfortunately I'm already developing my own extension for Firefox Quantum (https://addons.mozilla.org/fr/firefox/addon/cookie-quick-manager/) and it takes me a lot of time; for now I'm trying to run this extension (and it runs on my computer ><) because Thunderbird is a must have software used daily and the space saving in the taskbar is essential.
However, I do not exclude working on an addon based on webextensions because all addons using js-ctypes are doomed to disappear.
@ysard Thank you! It is understandable you are doing enough by keeping it alive.
Then the best hope is to get this integrated into TB. To others, as my previous comment says if you are interested go on bugzilla, comment and vote!
@ysard I found the problem. Path for Windows was indeed broken. I did sent PR to your fork. Now it should work 🎉
@ysard @kolinger Just installed the latest version from https://github.com/ysard/mintrayr/tree/dev_thunderbird_60+ on my Win10 and it seems to work like a charm! Thank you so much! :)
I noticed a problem on Windows 7: The contextual menu supposed to be triggered after a right click is not displayed (if the option to displayed it is checked). Am i the only one? I had to tweak the code that calls the showPopup() method (in mintrayr.jsm) because it was not working, even on Linux, but there is a problem on Windows : no menu and no error is thrown.
Yes. It is acting weirdly. Right click works only when Thunderbird window is not minimized. But even then its in weird position. It is aligned to right and bottom of screen. Not where icon/mouse is. Right click when Thunderbird is minimized does nothing. Log is indeed empty. Strange...
Idem, i am confused here... An issue is opened on my repository to avoid going out of the subject of this thread: https://github.com/ysard/mintrayr/issues/3
Thanks very much to make it available again for TB 60+ :)
I cannot seem to get this working. It installs fine, but doesn't seem to function. I had the predecessor installed prior to this, but got the "Quantum" update which feels like a giant step backwards and it quit working.
@DemonfangArun : Ok, try to fully remove the addon and reinstall it. Maybe the folders have not been reset during the update.
Then, make the following combination of keys: Ctrl+Maj+J, maybe errors related to mintrayr are visible...
@DemonfangArun : Ok, try to fully remove the addon and reinstall it. Maybe the folders have not been reset during the update.
Then, make the following combination of keys: Ctrl+Maj+J, maybe errors related to mintrayr are visible...
I ended up backdating thunderbird to 56 and canning updates. I installed it after the update, so it wouldn't be that.
@DemonfangArun The changes were made for Thunderbird 60 and up. All changes since version 57 have been applied in the code. This is probably the reason of your problem. The manifest also specifies that the accepted minimum version of Thunderbird is 60 :)
That was read in the wrong order methinks. I installed this on 60, after updating, and it didn't work. I then decided to go back to 56 and use the appropriate addon for that version.
Understood; In this case the logs in the console can be quite informative for me :) If you reinstall this addon again, do not hesitate to create an issue on the github.
+1 just CANNOT get this to work in Windows 10. So very frustrating
@ysard I think, I found an issue
your updated Addon is not working for me. Thunderbirds console shows me the following NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIZipReader.open] - trayservice.jsm:75
I thing this happens, because i have a space in my user folder.
for example:
C:\Users\John Doe\AppData\Roaming\Thunderbird
I think, this causes the error.
It would be gread, if you could fix it in your next release.
Thanks
@SeppiW : There is indeed an issue here, i have a patch for Linux, i will test it on Windows tomorrow. The issue is here: https://github.com/ysard/mintrayr/issues/5
@SeppiW : There is indeed an issue here, i have a patch for Linux, i will test it on Windows tomorrow. The issue is here: ysard#5
This would explain it for me too, I also have a space in the username.
This worked on my Win 10 x64. Thank you @ysard Keep up the good social work...
@ysard @kolinger Just installed the latest version from https://github.com/ysard/mintrayr/tree/dev_thunderbird_60+ on my Win10 and it seems to work like a charm! Thank you so much! :)
Hi, I worked for a lot of hours to try to run this addon on Thunderbird 60.
Here is my repository: mintrayr: dev_thunderbird_60 + branch.
And the page on AMO, waiting for validation (hoping that it will be done quickly): https://addons.thunderbird.net/en-US/thunderbird/addon/minimizetotray-reanimated/ .
Can people test if my changes are working on all systems?
Thanks a lot. Works on my system. win 10 x64 thunderbird 60.0 (32 bit)
Hi, I worked for a lot of hours to try to run this addon on Thunderbird 60.
Here is my repository: mintrayr: dev_thunderbird_60 + branch.
And the page on AMO, waiting for validation (hoping that it will be done quickly): https://addons.thunderbird.net/en-US/thunderbird/addon/minimizetotray-reanimated/ .
Can people test if my changes are working on all systems?
Recently I've downloaded your add-on, and I have to say that is working fine for me. Using last version of Windows 10. Thank you and congratulations.
@revondage and @BehroozJanfada : Good news, thank you for the review :)
It won't install in linux with thunderbird 60.2.1 64 bit:
~ $ thunderbird
[calBackendLoader] Using Thunderbird's builtin libical backend
console.log: "XPCOMABI:" "x86_64-gcc3"
console.log: "DLL full path:" ({})
1539746761522 addons.xpi-utils WARN updateMetadata: Add-on mintray-reanimated@ysard is invalid: Error: Directory /home/marcelo/.thunderbird/vt0ork7i.default/extensions/mintray-reanimated@ysard does not contain a valid install manifest (resource://gre/modules/addons/XPIInstall.jsm:790:11) JS Stack trace: loadManifestFromDir@XPIInstall.jsm:790:11
loadManifestFromFile@XPIInstall.jsm:926:10
syncLoadManifestFromFile@XPIProvider.jsm:938:3
updateMetadata@XPIProviderUtils.js:1259:21
processFileChanges@XPIProviderUtils.js:1485:26
getNewSideloads@XPIProvider.jsm:3363:7
the file seems to be there though:
~ $ ls -lsh /home/marcelo/.thunderbird/vt0ork7i.default/extensions/mintray-reanimated\@ysard.xpi
356K -rw------- 1 marcelo marcelo 356K Oct 17 11:46 /home/marcelo/.thunderbird/vt0ork7i.default/extensions/mintray-reanimated@ysard.xpi
content seems fine, maybe manifest format needs update?
~/test $ unzip /home/marcelo/.thunderbird/vt0ork7i.default/extensions/mintray-reanimated\@ysard.xpi
Archive: /home/marcelo/.thunderbird/vt0ork7i.default/extensions/mintray-reanimated@ysard.xpi
extracting: install.rdf
extracting: icon.png
extracting: icon64.png
extracting: LICENSE
extracting: chrome/icons/default/MinTrayR.ico
extracting: defaults/preferences/mintrayr.js
extracting: lib/tray_x86-msvc.dll
extracting: lib/tray_x86_64-msvc.dll
extracting: lib/tray_i686-gcc3.so
extracting: lib/tray_x86_64-gcc3.so
extracting: lib/SOURCES
extracting: lib_unix/tray/export-versionscript
extracting: lib_unix/tray/tray.c
extracting: lib_unix/tray/tray.h
extracting: lib_win/tray/dllmain.c
extracting: lib_win/tray/tray.cpp
extracting: lib_win/tray/tray.h
extracting: lib_win/tray/exports.def
extracting: lib_win/tray/tray.rc
extracting: lib_win/tray/tray.sln
extracting: lib_win/tray/tray.vcproj
extracting: modules/mintrayr.jsm
extracting: modules/preferences.jsm
extracting: modules/trayservice.jsm
extracting: chrome.jar
extracting: chrome.manifest
No it's an unresolved bug for the moment, despite a few hours spent trying to understand its origin. The only way to solve the problem is to install the addon in a folder other than 'extensions' in the profile. The problem is that the uninstallation of the addon will be imperfect, because I have currently no way to the delete this folder during this process. See https://github.com/ysard/mintrayr/issues/7
Hi again. Please give me an example how to install the add-on in a folder other than 'extensions'. Do you maybe mean just to copy/paste the add-on from 'extensions' to an other folder (?name?) ? Is it sure what thunderbird will do in this case ?
Here you will find what you want (a specific version for the current problem): https://github.com/ysard/mintrayr/releases/tag/1.4.6dev
A temporary alternative : https://github.com/hanspr/ThunderTray For anyone that can not implement the previous workaround or wishes something more simple while we get a new Extension that works.
@revondage: Great work. This one does the job for me (win10 x64).
Thanks.
Hi, I worked for a lot of hours to try to run this addon on Thunderbird 60.
Here is my repository: mintrayr: dev_thunderbird_60 + branch.
And the page on AMO, waiting for validation (hoping that it will be done quickly): https://addons.thunderbird.net/en-US/thunderbird/addon/minimizetotray-reanimated/ .
Can people test if my changes are working on all systems?
it works on Archlinux with Cinnamon, thank you so much @ysard !!
Changed the profile path on Win10 (no spaces) and worked for me, thanks!
Just one little thing: when minimized, right mouse button doesn´t work. Need to restore Thunderbird window to fully close program.
Thanks again.
Hi, I have openSUSE Leap15 installed with KDE-Plasma 5.14.2,KDE-Frameworks 5.51.0, Qt 5.11.2. Thunderbird 60.3 is installed. The Version https://github.com/ysard/mintrayr/releases/tag/1.4.6dev works well. :-) Thanks
Thank you so much!!!! Works perfect with Windows 7, Thunder 60.3 (32-bit) Doesn't work yet with 6.4 but easy to downgrade in order to use this add-on.
Hi, I worked for a lot of hours to try to run this addon on Thunderbird 60.
Here is my repository: mintrayr: dev_thunderbird_60 + branch.
And the page on AMO, waiting for validation (hoping that it will be done quickly): https://addons.thunderbird.net/en-US/thunderbird/addon/minimizetotray-reanimated/ .
Can people test if my changes are working on all systems?
If there is a gap in the path to the email profile, this add-on doesn't work for example: c:\email profile. If it is free of gaps it works for example: c:\email_profile
Thanks in advance Tested on W7 & W10
//EDIT 1.4.6 work perfect! Thanks
Works like a charm on W10-64 Thank you for the hard work
I'm on 8.1 x64 with Thunderbird 60.3.0 and it seems that MTT revived is not compatible with this version? Do I have to disable some flag or option?
Hi, I have openSUSE Leap15 installed with KDE-Plasma 5.14.2,KDE-Frameworks 5.51.0, Qt 5.11.2. Thunderbird 60.3 is installed. The Version https://github.com/ysard/mintrayr/releases/tag/1.4.6dev works well. :-) Thanks
Thanks .. it's working also with Thunderbird-60.2.1 on Fedora27!
Hi, I just installed the latest version of Thunderbird and I am having trouble with MinimizeToTray. It wont work with version 60 :
Options come up and you can select each of the radio buttons directly but no changes are save and you have to exit Thunderbird to get functionality back.