search

nmaier / mintrayr

Mozilla extension: Minimize windows into the system tray (Firefox, Thunderbird, Seamonkey, Instantbird)
https://tn123.org/mintrayr/
Mozilla Public License 2.0
84 stars 37 forks source link

Right Click on tray icon no longer works #50

Closed Skiewuff closed 12 years ago

Skiewuff commented 13 years ago

After updating to Firefox 6.x

Nothing happens, no context menu. The check box at the option doesn't change anything.

felix-kolbe commented 13 years ago

Same for me. Still no menu on FF7.0.1 @Win7x32

SirLogician commented 13 years ago

I second this bug. I'm using windows vista 32 bit Firefox 7.0.1. System tray icon does not have context menu even though this option is turned on. It was same with firefox 7.0.0 and 7.0.1 upgrade didn't fix it.

ghost commented 13 years ago

Same for me. Still no menu on FF7.0.1 @Win7x32

r0polach commented 12 years ago

Any chance to fix this annoying bug?

Ryrynz commented 12 years ago

Hasn't been working for me either. Disabled all addons, Pale Moon and Firefox.

jeromeparies commented 12 years ago

Hello, I am using MinTrayR 1.0.1 with Thunderbird 11.0.1 on Windows 7, and I think it's really too bad the context menu from the system tray is not working anymore!

Ryrynz commented 12 years ago

If you change the main option 'Minimize to Tray' to something other than 'Instead of closing' the context menu starts working.

pabdulin commented 12 years ago

This one bugged me for a long time. As author seems no so interested in this project right now, with info from Ryrynz comment, I managed to found a bug which causes it (in Windows). In tray.cpp line 126:

    if (pl.showCmd == SW_SHOWMINIMIZED && (gWatchMode & kTrayOnMinimize)) {

must be replaced with: 

    if (pl.showCmd == SW_SHOWMINIMIZED) {

tested, and works perfectly now on my system (Win7 x64).

jeromeparies commented 12 years ago

Thanks for your replies! The workaround as proposed by Ryrynz also works on my system (MinTrayR 1.0.1 / TB 12.0.1 / Win7 x86). However, I can't get Pabdulin's solution to work. Any more experiences with these?

pabdulin commented 12 years ago

jeromeparies, you have to recompile the dll for this to work.

Ryrynz commented 12 years ago

Mind uploading and linking it please?

pabdulin commented 12 years ago

Sure, you can get it here: http://dl.dropbox.com/u/17003496/minimizetotray_PATCH.zip

Ryrynz commented 12 years ago

Cheers! The only issue with this build is that setting 'Minimize to Tray' to 'Instead of closing' also minimizes to tray when you minimize from the window. But at least I've got a tray icon that has a context menu and I can close Firefox normally now. If you sort that then this should be submitted as a new version.

pabdulin commented 12 years ago

I don't think it's possible to fix due to a bug in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=502457 . So it's either popup menu working properly, or minimize button behaviour. Personally I prefer first option.

Skiewuff commented 12 years ago

Finally. Amusing, that now what Ryrynz said is happening, but I guess now at least people have a choice between the two bugs :) Since this has been opened for 8 months, I'm guessing this is as good as it gets for now.

jeromeparies commented 12 years ago

@pabdulin: Sorry for the late reply, still many thanks! Using your modification ever since (TB15 now), preferring the popup menu working properly, too :)

pabdulin commented 12 years ago

I'm glad to hear that :), thank you.

nmaier commented 12 years ago

Ok, recreated with all the necessary details as issue #88

pabdulin commented 12 years ago

@nmaier Thank you for the plug-in and for the long-awaited fix :)

jeromeparies commented 11 years ago

@nmaier Quite late I admit, but still a very sincere THANK YOU ! Enjoying your fix every single day :) @all Thanks to you too for you input ;) Please keep up the good (community) work!