nmalkin / kpi-dashboard

dashboard for visualizing key performance indicators for Mozilla Persona
7 stars 4 forks source link

Axes and hover details disappear after empty series is displayed #11

Closed nmalkin closed 12 years ago

nmalkin commented 12 years ago

To reproduce:

  1. Open New user flow report
  2. Select from and to dates to be equal and reload if necessary so that all data goes away
  3. Expand date range

Data will reappear, but not the axes and hover details.

The problem Rickshaw falls apart when no data is displayed. 181851c86f5d19f1e6de1f5d5463cf2329cca90d introduced a fix for this that catches the exception when the graph is being updated and redraws it (from scratch). However, the axes and hover details are not being recreated.

The solution will be to recreate the appropriate axes based on the report. Or figure out why Rickshaw's breaking on empty series. But, you know, probably the former.