search

nmangue / NGrib

NGrib is a .NET library to read GRIB (GRid in Binary) files. GRIB is a gridded data standard from WMO (World Meteorological Organisation) and is used by many meteorological organisation. Fork of GribCS.
GNU Lesser General Public License v3.0
17 stars 10 forks source link

Missing grib2 definitions #2

Closed pgchekill closed 3 years ago

pgchekill commented 3 years ago

Hi,

While trying to parse data from the ICON-EU model, I saw that the parameter that was of interest to me was missing from the code tables. The result is that the parameter field of the definition section is set to null.

The parameter in question is 52 from table 4.2 or Total Precipitation Rate (TPRATE). (ref: [https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-0-1.shtml])

Would be ok to add some missing Grib2 definitions ?

Best.

nmangue commented 3 years ago

Hello,

Yes, it would be nice to have more definitions. Do you want to submit a PR ?

In the mean time, even tough Parameter is null, you can use ParameterCategory and ParameterNumber that contains the related indexes (the discipline is in the IndicatorSection).

Best regards

Le jeu. 19 août 2021 à 17:06, pgchekill @.***> a écrit :

Hi,

While trying to gather parse data from the ICON-EU model, I saw that the parameter that was of interest to me was missing from the code tables. The result is that the parameter field of the definition section is set to null.

The parameter in question is 52 from table 4.2 or Total Precipitation Rate (TPRATE). (ref: [ https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-0-1.shtml ])

Would be ok to add some missing Grib2 definitions ?

Best.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nmangue/NGrib/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5ISJAZODWUFDP4K3Z7VCDT5UMXNANCNFSM5CONR5SQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

pgchekill commented 3 years ago

Hi,

As suggested, I've submitted a PR for the modification of parameter definitions. I only completed category 0 and 1 of table 4.2.

And you're right, in my code I was able to to determine the parameter by the index instead of the parameter object. But I thought it would be nice to have the "correct" definition. Your library is pretty neat to use 👍

Best regards

nmangue commented 3 years ago

Thank you very much for your comment and your contribution !