search

nmarus / node-ews

A simple JSON wrapper for the Exchange Web Services (EWS) SOAP API.
MIT License
116 stars 52 forks source link

Refix problem fixed #38

Closed eino-makitalo closed 7 years ago

eino-makitalo commented 7 years ago

It seems that this fixWsdl is called many times. So this check prevents fixing (aka adding -block multiple times to system). Maybe there are better way to prevent system to call this fix-routine so many times? reject this if you have some better approach :-)

nmarus commented 7 years ago

Hmm... I see where calling ews.init() multiple times in the same application could do this, or if using the options to specify a temp directory where init() is then just repeatedly appending the fix.

A fix for the latter is definitely needed, but curious if you are seeing multiple calls to init() / fixWsdl() in some other scenario I am missing?

nmarus commented 7 years ago

Just applied a modification of your fix along with a few other cleanup items.

eino-makitalo commented 7 years ago

You are probably right. I have temp dir set in options. And I have also initialized this directory with wsdl and xsd files now. So I have not tested if this happens without temp dir set.