Sanitize source name - Githubissues

nmattia / niv

Easy dependency management for Nix projects

https://github.com/nmattia/niv

MIT License

1.55k stars 77 forks source link

Sanitize source name #265

Closed nmattia closed 4 years ago

nmattia commented 4 years ago

The file sources didn't get a name, and didn't get their name sanitized. This also fixes a bug where builtins_fetchTarball would fail if because no name was given.

Fixes #264 Fixes #262

infinisil commented 4 years ago

Related: With https://github.com/NixOS/nixpkgs/pull/83241 there's a function for this in nixpkgs

nmattia commented 4 years ago

Ah that's great! I'll steal that.

EDIT: @Infinisil or maybe you want to submit a PR?

infinisil commented 4 years ago

Feel free to use it, I won't make a PR (was just passing by the issue tracker when I saw this).

nmattia commented 4 years ago

@Infinisil done. Love the split bit, very smart.