search

nmattia / niv

Easy dependency management for Nix projects
https://github.com/nmattia/niv
MIT License
1.52k stars 74 forks source link

updated readme from release-21.05 to nixos-unstable #378

Closed eyJhb closed 8 months ago

eyJhb commented 9 months ago

The readme.md does not reflect how niv current handles init, as it no longer follows the release-xxx branch, but instead unstable.

This might cause confusion for some, as they will try to use release-xxx branch, which shouldn't be used (AFAIK), but if one wants to pin to a stable branch nixos-xxx or nixpkgs-xxx should be used instead :)

eyJhb commented 8 months ago

No problem! - if you can do it easily, then go ahead, otherwise I'll try to do it tomorrow :)

Thanks for this great project!

On 16 October 2023 15.16.26 CEST, Nicolas Mattia @.***> wrote:

@nmattia approved this pull request.

Oh yes, that's correct! Thanks a lot!

CI will probably fail because README.md & README.tpl.md are not in sync. You can easily fix this by copying your changes to README.tpl.md, or let me know and I'll push to your branch!

-- Reply to this email directly or view it on GitHub: https://github.com/nmattia/niv/pull/378#pullrequestreview-1679964922 You are receiving this because you authored the thread.

Message ID: @.***>

eyJhb commented 8 months ago

Should be fixed now ;)

nmattia commented 8 months ago

Thank you @eyJhb !