search

nmattis / spicetify-extensions

Custom extensions for spicetify-cli (https://github.com/khanhas/spicetify-cli)
MIT License
8 stars 0 forks source link

Does not work #1

Open FFGamer04 opened 3 years ago

FFGamer04 commented 3 years ago

Installed through powershell usingspicetify config extensions saveDiscoverWeekly.js. No errors whatsoever. Although, the button to save doesn't appear. Spotify Version: 1.1.61.583.gad060c66-a Spicetify version: Latest

nmattis commented 3 years ago

Hi! Thanks for pointing this out to me. I haven't been able to fully verify yet as 2.5.0 is currently broken for me on the latest spotify version but I was looking through issues on the spicetify project and I'm fairly confident it's not working on the latest version because the context menu react hook is broken see https://github.com/khanhas/spicetify-cli/pull/945 . This extension relies on that component to inject the new menu option.

I'll keep an eye on things and update this issue as I figure more out. For now if you want to use this extension I recommend down grading both the cli and Spotify client version as recommend in the issue thread tied to that PR.

nmattis commented 3 years ago

So after looking deeper into this it also looks like they deprecated and changed some of the object interfaces that this extension relied on. I'll work on updating the code and get a fix out.

I'll be testing my fixes with this patched version https://github.com/itsmeowForks/spicetify-cli/releases/tag/v2.5.0-patch3

Don't really have a timeline on when I'll be able to get this done though, hopefully soon.

itsmeow commented 3 years ago

The ContextMenu hook is no longer working, so it's very likely that you won't be able to get it working, even on my patch.

itsmeow commented 3 years ago

ContextMenu hook reimplemented. New patch up soon.

nmattis commented 3 years ago

Awesome yea I was working on using the new interfaces and then realized that, thanks for the info @itsmeow will give it a shot with that new patch👍