search

nmaupu / freenas-provisioner

Kubernetes external provisioner using Freenas as backend
Apache License 2.0
132 stars 26 forks source link

Add support for mountOptions #18

Closed Elegant996 closed 5 years ago

Elegant996 commented 5 years ago

mountOptions was recently deprecated and support was added through StorageClass.mountOptions upstream. In order to support this functionality, two dependencies must be updated for PersistentVolumeSpec.

travisghansen commented 5 years ago

This looks pretty cool. Is the scope of this setting per class then?

Elegant996 commented 5 years ago

Sorry, I was busy after I submitted this. Yes, the scope of this is per class due to it now being offered as an option by StorageClass. This change was made to the StorageClass back in November and replaces the initial design proposal.

The only workaround I can suggest for those that require different mount parameters for different shares would be to deploy another provisioner with the required options and use it instead.

I myself only needed this for basics such as hard, nfsvers=4.1, and noatime on all my shares.

Thanks!

nmaupu commented 5 years ago

Looks good to me, I don't see any problems running multiple storage class / freenas-provisioner if need be.