AP Proto definition. - Githubissues

nmcb / dads

Reading and counter storage

The Unlicense

0 stars 0 forks source link

AP Proto definition. #8

Closed bartbuijse closed 3 years ago

nmcb commented 3 years ago

@bartbuijse Please fix the build in this branch. Would like to pick up this work on Friday. Thx!

nmcb commented 3 years ago

@bartbuijse when adding a signature to an existing interface trait with existing implementations in the code base, in scala, you can fix the compilation errors by providing a non-implementation to the method body, like def foo = ???. (as a sidenote, i suggest we talk english on github (as in the codebase) since the code may live for a long time and may likely be read by programmers sharing only english as a language.

nmcb commented 3 years ago

regardless of my comment above: i see you bundled a couple of additional signatures and a service that are out of scope for the point-to-point we're currently focussing on in the last two commits. fasted way forward is probably if you revert and move those change implementation requests to a separate pr so that i can merge this one and start implementing GetMeasurements.

nmcb commented 3 years ago

@bartbuijse can you have a look at the definition, i cleaned it up a bit and added comments;

removed message definitions that were not used
annotated with [prod/arch] comments to differentiate between productional field values and hardcoded/ignored values

nmcb commented 3 years ago

@bartbuijse i restored the branch because im missing the inbound indication and request units of measurement in the proto interface specification, sorry for having your pr merged too quickly, my bad!

shall we spend wednesday filling in the details from the dads volume history specification together ?

nmcb commented 3 years ago

superseded by https://github.com/nmcb/dads/pull/18 deleting branch