search

nmcteam / mulch

A frontend gulpfile boilerplate that uses Twig.js, LESS and/or SASS compilation and BrowserSync. Perfect for PHP CMS projects.
MIT License
15 stars 5 forks source link

Added Gulp-Data plugin to replace jsoncombine #4

Closed colynb closed 8 years ago

colynb commented 8 years ago

I replaced jsoncombine with gulp-data plugin which most gulp template engines use to inject data with now. This decouples data as a separate function from twig itself. Also, because of this I was able to remove the jsoncombine task, which was depended on by the twig task.

colynb commented 8 years ago

@JoelSutherland I forgot to remove the require('jsoncombine') line in the gulpfile.js

JoelSutherland commented 8 years ago

Good catch -- just removed it.

olets commented 8 years ago

@colynb foreach was just deprecated, and npm is doing its grumpy thing:

Either use gulp-tap or gulp-flatmap, depending on your needs

Feel like taking a stab at it?