nmcteam / mulch

A frontend gulpfile boilerplate that uses Twig.js, LESS and/or SASS compilation and BrowserSync. Perfect for PHP CMS projects.
MIT License
15 stars 5 forks source link

Feature/gulp clean css #7

Closed olets closed 8 years ago

olets commented 8 years ago

Dropped gulp-minify-css in favor of gulp-clean-css, as encouraged by npm

JoelSutherland commented 8 years ago

I looked into this briefly before and I'm not 100% sure it's a 1:1 replacement. clean-css appears to do a bit more than minify by default. I think we need to pass in a few options.

olets commented 8 years ago

I think those come into play when using clean-css for compilation - e.g. if we had a folder of css files and just ran it on them. With mulch, and maybe this is because of the result of the less compilation, I'm getting identical all.min.css from minify-css and clean-css

JoelSutherland commented 8 years ago

Cool -- I'm merging it in.

I'm about to start a new project so I'll keep an eye on this.