search

nmdias / FeedKit

An RSS, Atom and JSON Feed parser written in Swift
MIT License
1.19k stars 174 forks source link

Adds support for handling bad URLs using NSXMLParser's built in functionality #1

Closed brettohland closed 8 years ago

brettohland commented 8 years ago

If passed a URL that doesn't resolve to a feed, the framework never calls it's completion block.

My code simply uses the NSXMLParser's boolean return value on its parse method to detect a failure and passes along the included NSError object.

brettohland commented 8 years ago

Added test coverage for change.

nmdias commented 8 years ago

Great contribution @brettohland :)

Thanks